Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Check server requirements before creating any files and directories #151

Closed
SharakPL opened this issue Sep 13, 2020 · 4 comments

Comments

@SharakPL
Copy link

SharakPL commented Sep 13, 2020

When I create new app with laravel new myapp I get an error:

Your requirements could not be resolved to an installable set of packages.

Problem 1

  • phpunit/phpunit 9.4.x-dev requires ext-dom * -> the requested PHP extension dom is missing from your system.
    ...

I know this is a one time issue and goes away with installing missing php extensions, but would it be possible to do this checking before creating any app folders including /myapp?

@SharakPL SharakPL changed the title Check server requirements before creating any files and directories [Feature request] Check server requirements before creating any files and directories Sep 13, 2020
@driesvints
Copy link
Member

@SharakPL feel free to PR if you want

@SharakPL
Copy link
Author

SharakPL commented Sep 14, 2020

@driesvints can you tell me which script/package in Laravel is responsible for checking requirements? ...or maybe it's composer doing the checking?

@driesvints
Copy link
Member

It'll need to be done inside the installer somewhere. Probably where composer is run.

@SharakPL
Copy link
Author

SharakPL commented Sep 14, 2020

I know, but which script does the checking in current state? Is it in laravel somewhere (I assume it is as it downloads laravel package before checking requiements) or maybe composer does that automatically or is it already in laravel/installer (just not in the right order)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants