Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary migration prompt when database connection settings are not configured #324

Closed
yourchocomate opened this issue Mar 16, 2024 · 1 comment

Comments

@yourchocomate
Copy link

yourchocomate commented Mar 16, 2024

Problem: Fresh installation of laravel using any database driver rather than sqlite starts with an error of can't connect with database.

installer-default-web

Description:
Current installer database selection steps are -

  • Prompt to select database driver
  • Confirmation to run migration of default migrations

So, Here the problem arises, database selection is okay but asking for migration with default configuration is a bit silly I guess. It's better to ask the user if they want to configure the conncetion settings. And then migrate or not.

And my suggestive steps would be:

  • Prompt to select database driver
  • Confirmation to set custom connection setting
    • Yes: Prompt to enter the custom settings for (HOST, PORT, DATABASE, USERNAME, PASSWORD) and set default value for migration prompt to true
    • No: Set default value for migration prompt to false
  • Migration prompt

Comparison:

Default installer -
installer-default

Patched Installer -
installer-yourchocomate

Finally, default installer serves my first laravel project with Error on homepage. And patched installer serves project with fresh start

A PR can be made if approves.

@taylorotwell It would be best if you look for it and give a proper suggestion on this, Thank You

@driesvints
Copy link
Member

Heya. Please just attempt a PR with whatever you'd like to propose. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants