Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Fortify CreateNewUser Action Stub Being Published #167

Closed
gradedcatfood opened this issue Sep 12, 2020 · 0 comments
Closed

Incorrect Fortify CreateNewUser Action Stub Being Published #167

gradedcatfood opened this issue Sep 12, 2020 · 0 comments

Comments

@gradedcatfood
Copy link
Contributor

gradedcatfood commented Sep 12, 2020

  • Jetstream Version: 1.1.2
  • Jetstream Stack: Inertia
  • Laravel Version: 8.1.0
  • PHP Version: 7.4.9
  • Database Driver & Version: mySQL

Description:

When running The laravel installer or jetstream install command, the CreateNewUser Fortify Action generated does not match the stub within the fortify project.

For example. within the fortify package the CreateNewUser Fortify Action uses the proper PasswordValidationRules trait for the password validator. When that stub is published to my project, the CreateNewUser Action does not use the PasswordValidationRules trait and instead has 'password' => ['required', 'string', new Password, 'confirmed'],

I've tried removing any composer cache but it continues to happen.

``

Steps To Reproduce:

laravel new laravel8-jet --jet

Select inertia, and no teams

OR

laravel new laravel8-jet
composer require laravel/jetstream
php artisan jetstream:install

Now view the laravel8-jet/app/Actions/Fortify/CreateNewUser file and compare to the package's stub version.

Here is a screenshot of Fortify's stub and Jetstream's stub:

Screenshot from 2020-09-12 14-14-25

@gradedcatfood gradedcatfood changed the title Incorrect Fortidy CreateNewUser Action Stub Being Published #30 Incorrect Fortify CreateNewUser Action Stub Being Published #30 Sep 12, 2020
@gradedcatfood gradedcatfood changed the title Incorrect Fortify CreateNewUser Action Stub Being Published #30 Incorrect Fortify CreateNewUser Action Stub Being Published Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants