Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code tags alignment on browsers that use different default baseline #175

Merged
merged 1 commit into from May 31, 2021
Merged

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented May 31, 2021

Follow-up to #153 (and the subsequent #154).

On browser Pale Moon, the code tags are shifted up, which makes reading the documentation quite tedious. That seems to be because Pale Moon applies a different default baseline, closer to the specifications, than Firefox and Chrome.

For more details you may read this topic on Pale Moon forum.

@driesvints
Copy link
Member

Please post a screenshot of how this fixes something, thanks

@wolfbeast
Copy link

Regression from #153 and #154

This PR fixes the following current behavior:
Image1

After patch:
Image2

@driesvints
Copy link
Member

And the behavior in Chrome, Safari, Firefox, Edge stays the same?

@wolfbeast
Copy link

It should, considering they apparently already use middle as the default behaviour if not specified. Made a quick test in Firefox since I have that readily available and it's fine.

@taylorotwell taylorotwell merged commit 882c568 into laravel:master May 31, 2021
@vlakoff vlakoff deleted the code_tags branch June 2, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants