Laravel Scout issue in initializeQueryUsingScout implementation

[nunomaduro]

• Laravel Version: 5.7.19
• Nova Version: 1.2.1
• PHP Version: 7.3

Description:

The current implementation of the method PerformsQueries::initializeQueryUsingScout assumes that the method Searchable::getScoutKey always returns getKey. So when you run scout:import, normally, objectID at Algolia will be 1, 2, etc.

The problem is Searchable::getScoutKey method can be actually override by the developer, returning something else, like App\Model::1. Each leads to a search with no results.

The solution is get models instances from the scout search, and using the getKey to get models keys:

    protected static function initializeQueryUsingScout(NovaRequest $request, $query, $search, $withTrashed)
    {
        $keys = tap(static::applySoftDeleteConstraint(
            static::newModel()->search($search), $withTrashed
        ), function ($scoutBuilder) use ($request) {
            static::scoutQuery($request, $scoutBuilder);
-       })->take(200)->keys();
+        })->take(200)->get()->map->getKey();

        return static::applySoftDeleteConstraint(
            $query->whereIn(static::newModel()->getQualifiedKeyName(), $keys->all()), $withTrashed
        );
    }

[bonzai]

This has been fixed and will be included in the next release.