Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Composer v2 and packages requiring Nova #3019

Closed
chosten opened this issue Nov 3, 2020 · 3 comments
Closed

Issue with Composer v2 and packages requiring Nova #3019

chosten opened this issue Nov 3, 2020 · 3 comments

Comments

@chosten
Copy link

chosten commented Nov 3, 2020

With Composer v2 I can't update my dependencies anymore.
It fails with packages requiring Nova like this: "laravel/nova": "^2.0|^3.0".
I think this is what I'm talking about: composer/composer#8890

I don't know who should fix the problem, Nova, the packages or Composer, But it can be fixed by adding a version to the composer.json of Nova, eg: "version": "3.14.0",.

Unless there is another way, could this be added to composer.json please ?

@crynobone
Copy link
Member

crynobone commented Nov 3, 2020

If you're downloading nova using zip and reference it using path you should be able to add the version on your own.

However AFAIK adding "version" can be done via the following:

cd nova
composer config version 3.14.0

I wasn't able to replicate the issue when requiring laravel/nova using composer installation.

@ziming
Copy link

ziming commented Nov 3, 2020

I believe most installations of nova is with the path method, partly because of how unstable nova is between releases that we need to be able to easily edit the package files to fix things while we wait for the next release. (but it is improving!)

Although we can add "version": "3.14.0" to nova composer.json ourselves, it requires us to always remember to do so. Hence I think it will be good if the nova team can do it until a better way to fix this is found.

@crynobone
Copy link
Member

We are discussing this internally at the moment but for the time being above is a quick solution until we can have a permanent direction (without downgrading to composer v1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants