Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PHP 8 support #3087

Closed
iruoy opened this issue Nov 27, 2020 · 20 comments
Closed

No PHP 8 support #3087

iruoy opened this issue Nov 27, 2020 · 20 comments

Comments

@iruoy
Copy link

iruoy commented Nov 27, 2020

  • Laravel Version: 8.16.0
  • Nova Version: 3.15.0
  • PHP Version: 8.0.0

Description:

PHP 8 compatibility isn't included in the composer.json.

Detailed steps to reproduce the issue on a fresh Nova installation:

Try to install Laravel Nova on a machine with PHP 8.

@crynobone
Copy link
Member

Support for PHP 8 currently work in progress.

@Nielsvanpach Nielsvanpach mentioned this issue Dec 2, 2020
8 tasks
@davi5e
Copy link

davi5e commented Dec 4, 2020

For informational purposes, is there any timeline on this to set expectations accordingly?

@driesvints
Copy link
Member

driesvints commented Dec 4, 2020

Nova is currently blocked by Scout which is blocked by Algolia PHP Client itself. I've started working on a PR here: algolia/algoliasearch-client-php#644

I've given several options to take the PR further but it's mostly in the hands of Algolia now. The PR is failing on some Algolia keys which only they can look into. I'm going to pick up work on the PR hopefully on Monday to see if I can also get the PHP 7.4 & 8 builds to the point of the failing keys.

@tahacankurt
Copy link

Is there any update about this issue?

@driesvints
Copy link
Member

@tahacankurt if this issue is still open and doesn't have any new comments then no there wasn't any update.

@driesvints
Copy link
Member

driesvints commented Dec 15, 2020

Actually there is! We've removed the algolia dev dependency from scout so we could tag php 8 support but nova is still blocked through testbench dusk which is blocked by algolia.

@powellblyth
Copy link

Looks like Algolia is ready... algolia/algoliasearch-client-php#644 (comment)

@briandotdev
Copy link

Looks like Algolia is ready... algolia/algoliasearch-client-php#644 (comment)

And it sounds like it's thanks to @driesvints 👏

@davidhemphill
Copy link
Contributor

I believe this should be fixed due to https://github.com/laravel/nova/pull/1109. Will be pushed in the next release.

@mathieutu
Copy link

@davidhemphill Could we tag the release quickly? (even if it has just that in it)
It's blocking upgrades.

Thanks.

@iruoy
Copy link
Author

iruoy commented Dec 25, 2020

@mathieutu Nova (and other Laravel products) are released on wednesday, so it shouldn't be too long now.

@mathieutu
Copy link

@iruoy ok thanks, didn't know that!

@osteel
Copy link

osteel commented Jan 4, 2021

Sorry – is this available? I'm trying to update my setup after upgrading to PHP 8 and this is what I get:

Problem 1
    - laravel/nova[v3.9.0, ..., 3.18.0] require php ^7.2.5 -> your php version (8.0.0) does not satisfy that requirement.
    - Root composer.json requires laravel/nova ^3.9 -> satisfiable by laravel/nova[v3.9.0, ..., 3.18.0].

I can't seem to access Nova's repository (is it private?) so I'm not sure what has been done recently, nor if the release that was mentioned is available yet.

@mathieutu
Copy link

Nope, nothing tagged yet. (and actually the releases are not on Wednesday for laravel products, according to the previous release dates)

@osteel
Copy link

osteel commented Jan 4, 2021

@mathieutu thanks for the quick reply. Where do you see the release tags?

@crynobone
Copy link
Member

Laravel Nova scheduled released are every 2 weeks on Tuesday (US timezone) unless there a priority bugfix that we need to patch.

The support for PHP 8 should be released on the 5th of January (tomorrow)

@driesvints
Copy link
Member

All Laravel releases are usually done on Tuesdays.

@osteel
Copy link

osteel commented Jan 19, 2021

Hi there, I've upgraded Nova and as a result the Composer dependencies are correctly installing.

But I now get PDO method signature errors:

Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs)

This issue seems related. Essentially, the signature of PDOConnection::query() has changed with doctrine/dbal v2.12 for PHP 8 support, in a way that is incompatible with Nova.

Upgrading to doctrine/dbal v3 would apparently fix it, but Nova currently prevents it to maintain support for Laravel 7.

Is there a way around this or is PHP 8 effectively not supported yet?

Thanks

@driesvints
Copy link
Member

@osteel Upgrade both Laravel and DBAL 2.x to the latest versions. This should fix that.

@osteel
Copy link

osteel commented Jan 19, 2021

@driesvints I don't know how I missed that but it did the trick! Thanks for the quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants