New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No PHP 8 support #3087
Comments
Support for PHP 8 currently work in progress. |
For informational purposes, is there any timeline on this to set expectations accordingly? |
Nova is currently blocked by Scout which is blocked by Algolia PHP Client itself. I've started working on a PR here: algolia/algoliasearch-client-php#644 I've given several options to take the PR further but it's mostly in the hands of Algolia now. The PR is failing on some Algolia keys which only they can look into. I'm going to pick up work on the PR hopefully on Monday to see if I can also get the PHP 7.4 & 8 builds to the point of the failing keys. |
Is there any update about this issue? |
@tahacankurt if this issue is still open and doesn't have any new comments then no there wasn't any update. |
Actually there is! We've removed the algolia dev dependency from scout so we could tag php 8 support but nova is still blocked through testbench dusk which is blocked by algolia. |
Looks like Algolia is ready... algolia/algoliasearch-client-php#644 (comment) |
And it sounds like it's thanks to @driesvints 👏 |
I believe this should be fixed due to https://github.com/laravel/nova/pull/1109. Will be pushed in the next release. |
@davidhemphill Could we tag the release quickly? (even if it has just that in it) Thanks. |
@mathieutu Nova (and other Laravel products) are released on wednesday, so it shouldn't be too long now. |
@iruoy ok thanks, didn't know that! |
Sorry – is this available? I'm trying to update my setup after upgrading to PHP 8 and this is what I get:
I can't seem to access Nova's repository (is it private?) so I'm not sure what has been done recently, nor if the release that was mentioned is available yet. |
Nope, nothing tagged yet. (and actually the releases are not on Wednesday for laravel products, according to the previous release dates) |
@mathieutu thanks for the quick reply. Where do you see the release tags? |
Laravel Nova scheduled released are every 2 weeks on Tuesday (US timezone) unless there a priority bugfix that we need to patch. The support for PHP 8 should be released on the 5th of January (tomorrow) |
All Laravel releases are usually done on Tuesdays. |
Hi there, I've upgraded Nova and as a result the Composer dependencies are correctly installing. But I now get PDO method signature errors:
This issue seems related. Essentially, the signature of Upgrading to Is there a way around this or is PHP 8 effectively not supported yet? Thanks |
@osteel Upgrade both Laravel and DBAL 2.x to the latest versions. This should fix that. |
@driesvints I don't know how I missed that but it did the trick! Thanks for the quick response |
Description:
PHP 8 compatibility isn't included in the
composer.json
.Detailed steps to reproduce the issue on a fresh Nova installation:
Try to install Laravel Nova on a machine with PHP 8.
The text was updated successfully, but these errors were encountered: