Tool translations aren't forwarded to the front-end

[blackfyre]

• Laravel Version: 5.7.13
• Nova Version: 1.1.7
• PHP Version: 7.2.11

Description:

As per Laravel 5.7 docs, I've added the translations to my tool, and in the blade templates / Tinker / ... it works fine. I've expected this to be added to the Nova.config.translations object automatically to be used with __(), but that's not the case, only the Nova translations are added there.

The Nova::provideToScript([]) doesn't help in extending already present translations with the new ones.

[maslauskas]

solved this adding the following method to component file:

    /**
     * Get the translation keys from file.
     *
     * @return array
     */
    private function getTranslations()
    {
        $translationFile = __DIR__ . '/../resources/lang/'.app()->getLocale().'.json';

        if (! is_readable($translationFile)) {
            return [];
        }

        return json_decode(file_get_contents($translationFile), true);
    }

and then in component's boot method:

        Nova::provideToScript([
            'translations' => $this->getTranslations(),
        ]);

However, it overrides a bunch of other translations, which is not that great. Would love Nova to automatically include component translations in frontend.

[blackfyre]

@maslauskas I've already tried very similar things...

            Nova::provideToScript([
                'translations' => [
                    'proposal-items::' => __('proposal-editor::kpi')
                ],
            ]);

Nova::$jsonVariables['translations']['proposal-items::'] =  __('proposal-editor::kpi');

But nothing seems to work...

[maslauskas]

Got it to work with this in component's boot method:

        /** @var Translator $translator */
        $translator = app('translator');
        $translator->load('*', '*', app()->getLocale());
        $lines = $translator->getFromJson('*');

        Nova::provideToScript([
            'translations' => $lines
        ]);

Basically just loading all translations again and providing them to frontend...

Seems to me that at the time of passing json translations to frontend, component translations are not loaded yet, so maybe it's a simple issue of moving scripts around.

[blackfyre]

@maslauskas Still no dice... When I dump out the results of your snippet ($lines), I only get this:

 -------- ------------------------------------------------------------
  date     Thu, 15 Nov 2018 16:09:07 +0100
  source   ToolServiceProvider.php on line 36
  file     nova-components\my-resource-tool\src\ToolServiceProvider.php
 -------- ------------------------------------------------------------

"*"

[maslauskas]

Very strange. For me this little hack works as expected. Hopefully they add something to Nova that would load all component translations to frontend soon.

[blackfyre]

@maslauskas Still, this should be a core feature and not something that requires workarounds...

[blackfyre]

This is still an issue with Nova 1.2.1

[d3jn]

Nova provides translations to front using the following method:

/**
 * Get the translation keys from file.
 *
 * @return array
 */
private static function getTranslations()
{
    $translationFile = resource_path('lang/vendor/nova/'.app()->getLocale().'.json');

    if (! is_readable($translationFile)) {
        return [];
    }

    return json_decode(file_get_contents($translationFile), true);
}

Meaning you need to place your translations inside published resources/lang/vendor/nova directory.

[davidhemphill]

Hey there! In order to keep this repository focused on bug reports, we auto-close feature requests and requests for help. Feel free to post your feature requests so others can discuss and add reactions. We'll keep an eye on them for later planning.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.