Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developers can't know that the process is killed when it exceeds the maximum execution time. #183

Closed
eleven26 opened this issue Apr 12, 2021 · 1 comment
Closed

Developers can't know that the process is killed when it exceeds the maximum execution time. #183

eleven26 opened this issue Apr 12, 2021 · 1 comment

Comments

@eleven26
Copy link
Contributor

octane/src/Swoole/Actions/EnsureRequestsDontExceedMaxExecutionTime.php

Line 27 in 6054cc9

$this->extension->dispatchProcessSignal($row['worker_pid'], SIGKILL);

SIGKILL will kill the process directly, but we don't know it at all, but it's very helpful for us to improve the application if we know this situation.
@driesvints
Copy link
Member

Send in a PR if you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driesvints @eleven26