Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing config option for swoole server set? #98

Closed
viezel opened this issue Apr 6, 2021 · 3 comments
Closed

Missing config option for swoole server set? #98

viezel opened this issue Apr 6, 2021 · 3 comments
Assignees

Comments

@viezel
Copy link

viezel commented Apr 6, 2021

When looking at
https://github.com/laravel/octane/blob/master/bin/createSwooleServer.php#L20

Then are we not missing the following in the octane config?

'swoole' => [
    'options' => [
         // see https://www.swoole.co.uk/docs/modules/swoole-server/configuration
    ],
],

It would be great to be able to pass config to the swoole server set feature from the config/octane.php.

@jihadismail8
Copy link

jihadismail8 commented Apr 7, 2021

i agree !! i do not know why during swoole installation i answered all the questions by NO ( json , coroutine ..etc support ) but yet when i check up the configs of swoole i find out that coroutines are enabled . so this kind of enhancement would be really useful

@sy-records
Copy link
Contributor

@jihadismail8 Swoole's coroutine support is enabled by default, No option during installation

You can turn it off via php.ini

swoole.enable_coroutine=Off

@taylorotwell
Copy link
Member

For now I'm keeping the config clean but may add this later. You can add it to your own configuration file if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants