Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package zendframework/zend-diactoros is abandoned, you should avoid using it. Use laminas/laminas-diactoros instead #1167

Closed
camboYY opened this issue Jan 19, 2020 · 6 comments

Comments

@camboYY
Copy link

camboYY commented Jan 19, 2020

  • Passport Version: #.#.#
  • Laravel Version: #.#.#
  • PHP Version: #.#.#
  • Database Driver & Version:

Description:

Steps To Reproduce:

@JakeBooher
Copy link

@driesvints why was this closed?

@driesvints
Copy link
Member

It's already fixed in the latest release

@derekrprice
Copy link

I'm not sure this was ready. See issue #1179. It looks like there is some sort of BC break in laminas-diactoros.

@connecteev
Copy link

@driesvints I dont think this issue has been fixed.

Running composer require laravel/passport
on laravel 7
gives the following error:

Package zendframework/zend-diactoros is abandoned, you should avoid using it. Use laminas/laminas-diactoros instead.

All of these packages make use of zendframework/zend-diactoros:
laravel/passport
league/oauth2-server
symfony/psr-http-message-bridge

And this is from the composer.lock file

        {
            "name": "laravel/passport",
            "version": "v7.5.1",
            "source": {
                "type": "git",
                "url": "https://github.com/laravel/passport.git",
                "reference": "d63cdd672c3d65b3c35b73d0ef13a9dbfcb71c08"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/laravel/passport/zipball/d63cdd672c3d65b3c35b73d0ef13a9dbfcb71c08",
                "reference": "d63cdd672c3d65b3c35b73d0ef13a9dbfcb71c08",
                "shasum": ""
            },
"require": {
    "ext-json": "*",
    "firebase/php-jwt": "~3.0|~4.0|~5.0",
    "guzzlehttp/guzzle": "~6.0",
    "illuminate/auth": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/console": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/container": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/contracts": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/cookie": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/database": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/encryption": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/http": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "illuminate/support": "~5.6.0|~5.7.0|~5.8.0|^6.0|^7.0",
    "league/oauth2-server": "^7.0",
    "php": ">=7.1",
    "phpseclib/phpseclib": "^2.0",
    "symfony/psr-http-message-bridge": "~1.0",
    "zendframework/zend-diactoros": "~1.0|~2.0"
},

Also, calling composer require laravel/passport to upgrade passport directly doesnt work either:

$ composer require laravel/passport
Using version ^8.4 for laravel/passport
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for league/oauth2-server (installed at 7.4.0) -> satisfiable by league/oauth2-server[7.4.0].
    - laravel/passport 8.x-dev requires league/oauth2-server ^8.0 -> satisfiable by league/oauth2-server[8.0.0].
    - laravel/passport v8.4.0 requires league/oauth2-server ^8.0 -> satisfiable by league/oauth2-server[8.0.0].
    - laravel/passport v8.4.1 requires league/oauth2-server ^8.0 -> satisfiable by league/oauth2-server[8.0.0].
    - laravel/passport v8.4.2 requires league/oauth2-server ^8.0 -> satisfiable by league/oauth2-server[8.0.0].
    - laravel/passport v8.4.3 requires league/oauth2-server ^8.0 -> satisfiable by league/oauth2-server[8.0.0].
    - Conclusion: don't install league/oauth2-server 8.0.0
    - Installation request for laravel/passport ^8.4 -> satisfiable by laravel/passport[8.x-dev, v8.4.0, v8.4.1, v8.4.2, v8.4.3].

Installation failed, reverting ./composer.json to its original content.

@driesvints
Copy link
Member

@connecteev Passport and Laravel don't use this package anymore.

Try to remove your vendor and composer.lock file and run the passport require command.

@connecteev
Copy link

@driesvints removing the vendor directory fixed it..thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants