Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Laravel\Scout\Builder::withSearchParameters does not exist. #791

Closed
crivion opened this issue Jan 19, 2024 · 7 comments
Closed

Method Laravel\Scout\Builder::withSearchParameters does not exist. #791

crivion opened this issue Jan 19, 2024 · 7 comments
Assignees
Labels

Comments

@crivion
Copy link

crivion commented Jan 19, 2024

Scout Version

10.8

Scout Driver

Typesense

Laravel Version

10

PHP Version

10

Database Driver & Version

0

SDK Version

0

Meilisearch CLI Version

0

Description

I'm trying the new typesense scout integration.
In the docs it says

"Typesense allows you to modify your search parameters dynamically when performing a search operation via the withSearchParameters method:"

Todo::search('Groceries')->withSearchParameters([
'query_by' => 'title, description'
])->get();

However when try that it says:
Method Laravel\Scout\Builder::withSearchParameters does not exist.

Steps To Reproduce

Just install laravel scout and configure it to work with typesense

@jasonbosco
Copy link
Contributor

Related to this: laravel/docs#9250 (comment) (has a potential workaround for now in that comment).

@karakhanyans is actively looking into this.

@driesvints
Copy link
Member

@crivion you are using the typesense driver are you? because the issue report says you're using the collection driver?

@crivion
Copy link
Author

crivion commented Jan 22, 2024

@driesvints yes, you don't have an option when opening an issue to select typesense

SCR-20240122-lj8

@driesvints
Copy link
Member

Ah thanks for noting that. I added it now.

@crivion
Copy link
Author

crivion commented Jan 22, 2024

No problem at all, more context if required (for whoever needs a quick ref)

SCR-20240122-lko

@karakhanyans
Copy link
Contributor

@driesvints @crivion @jasonbosco the issue has been fixed in this PR: #794

The withSearchParameters has been removed and instead we should use ->options() method.

@driesvints
Copy link
Member

Will be in today's release. @karakhanyans thanks for your PR. Also feel free to send one in to the docs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants