Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README states PHP 7.4+, but composer.json requires PHP 7.3+ #21

Closed
jonnott opened this issue Sep 30, 2021 · 3 comments
Closed

README states PHP 7.4+, but composer.json requires PHP 7.3+ #21

jonnott opened this issue Sep 30, 2021 · 3 comments

Comments

@jonnott
Copy link

jonnott commented Sep 30, 2021

..surely this wants to be in-tune with whatever the latest compatible laravel/framework requires, i.e. 7.3+ for L8.x?

@nunomaduro
Copy link
Member

nunomaduro commented Sep 30, 2021

Composer requires PHP 7.3 to make this package installable on Laravel 8.x. Yet, the package does not support PHP 7.3.

@jonnott
Copy link
Author

jonnott commented Sep 30, 2021

Composer requires PHP 7.3 to make this package installable on Laravel 8.x. Yet, the package does not support PHP 7.3.

This sounds like something could be broken for PHP 7.3 users then..?

@nunomaduro
Copy link
Member

nunomaduro commented Sep 30, 2021

@jonnott We proxy to opis/closure when users are using PHP 7.3: https://github.com/laravel/framework/blob/8.x/src/Illuminate/Queue/SerializableClosureFactory.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants