Namespace resolution missing for named parameter during serialization

[flavioheleno]

Serializable Closure Version

1.3.0

PHP Version

8.2.7

Description

Hi, I've hit an issue that I think may be a bug.
I previously thought it was was an issue in PHP-DI, but during my investigation I isolated it to this library (original report here: PHP-DI/PHP-DI#855).
Long story short: if a closure uses a combination of named parameters and a class that is not in the global namespace, it fails when the closure is unserialized.

Steps To Reproduce

// class.php
namespace My\Name\Space;
class MyClass {
  public const A = 1;

  public function __construct(string $arg1, int $arg2) {}
}

// main.php
require_once __DIR__ . '/vendor/autoload.php';
include __DIR__ . '/class.php';

use Laravel\SerializableClosure\UnsignedSerializableClosure;
use My\Name\Space\MyClass;

$closure = static function (): MyClass {
  return new MyClass(arg2: MyClass::A);
};

$s = serialize(new UnsignedSerializableClosure($closure));
var_dump(unserialize($s)->getClosure()());

$ php main.php 
PHP Fatal error:  Uncaught Error: Class "MyClass" not found in laravel-serializable-closure://static function (): \My\Name\Space\MyClass {
  return new \My\Name\Space\MyClass(arg2: MyClass::A);
}:3
Stack trace:
#0 /home/flavio/Documents/open-source/serialize-bug/main.php(14): {closure}()
#1 {main}
  thrown in laravel-serializable-closure://static function (): \My\Name\Space\MyClass {
  return new \My\Name\Space\MyClass(arg2: MyClass::A);
} on line 3

[driesvints]

Heya, thanks for reporting.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here? Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Please do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

[nunomaduro]

Actually, would be even better create a pull request with a failing test.

[flavioheleno]

Hey, I have a failing test that I was using to investigate, what should I do, follow @driesvints or @nunomaduro ?

[driesvints]

feel free to send in a draft pr with the failing test 👍

[flavioheleno]

@driesvints just did in #67 please let me know what else can I do to help :-)

[driesvints]

cool, thanks. Closing this now. Let's continue on the PR