Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google+ APIs being shutdown can we add patch to version 3.* #335

Closed
rajjanorkar opened this issue Jan 31, 2019 · 7 comments
Closed

Google+ APIs being shutdown can we add patch to version 3.* #335

rajjanorkar opened this issue Jan 31, 2019 · 7 comments

Comments

@rajjanorkar
Copy link

I got below mail from google, about google plus shutdown.

I am using socialite version 3, is it possible to add the fix in that version please.

thank you.

Dear Developer,

Earlier this week we sent you an email related to your projects that will be impacted by the Google+ API shutdown, which also affects requests for Google+ OAuth scopes.

The email listed that one or more of your projects are requesting the “plus.me” scope, and would thus be affected. We would like to clarify that only projects directly requesting the “plus.me” scope are affected. This scope may have been listed in some emails, even if not directly requested by your project. We apologize for any confusion caused.

If you are directly requesting the “plus.me” scope, any other Google+ OAuth scopes, or making any Google+ API calls, please ensure that you remove these requests from your project before March 7, 2019.

To see if your project is directly requesting the “plus.me” or any other Google+ OAuth scopes:

If your project is written in Google Apps Script, you can view which scopes your project is requesting by reviewing your project properties in App Script Editor.
If your project is not written in Google Apps Script, please check your code for references to “plus.me” in OAuth scope requests. We recommend that you review projects using any 3rd-party libraries that support sign-in or social functionality, as these may also be affected by the shutdown.
Thanks for being a valued Google+ Developer.

Sincerely,
The Google+ API team

@rajjanorkar
Copy link
Author

rajjanorkar commented Feb 1, 2019

I can see it has been fixed in version 4, can we release the same fix into version 3 (may be in v3.2.1)

@msonowal
Copy link

msonowal commented Feb 2, 2019

It is there in the code but it is not tagged
Please tag for version 3 for Google SignIn as all the Laravel 5.5 LTS users are effected
ping @taylorotwell @driesvints

@rajjanorkar
Copy link
Author

Hi guys,

anything can be done here.. please? My multiple apps needs update... and i guess many other peoples are facing issue...

@taylorotwell @lucasmichot @GrahamCampbell

@driesvints
Copy link
Member

You can require 3.0.x-dev

@msonowal
Copy link

msonowal commented Feb 5, 2019

@driesvints
I know we can use it like that but what i requested it to tag a release as it is stable and official working as per Google SignIn. as because all the LTS 5.5 users are affected I wanted you to tag that as soon as possible

@rajjanorkar
Copy link
Author

rajjanorkar commented Feb 5, 2019

@msonowal don't worry thats not gonna happen...

This guy @driesvints is in so much hurry wanna close all the issues created here without properly addressing it...

He will lock this as well... so basically we have to f**k ourself with that 3.0.x-dev branch.. (hope he understand what he is talking about)

@driesvints
Copy link
Member

@msonowal You can import the fix with the requirement I listed above. I don't see how a tag will help you more than that.

@rajjanorkar please realize the effort that goes into maintaining open source software and that you're using all of this for free. You can fork the repo, tag the branch and publish it on Packagist with a different vendor name if you really want that.

And yes I'm going to lock this because nothing good is going to come out of this discussion anymore.

@laravel laravel locked as too heated and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants