Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default scope delimiter to space #363

Closed
driesvints opened this issue May 7, 2019 · 4 comments
Closed

Change default scope delimiter to space #363

driesvints opened this issue May 7, 2019 · 4 comments

Comments

@driesvints
Copy link
Member

I believe a space is the more sensible default as I've not seen too many examples using comma's.

See discussion here as well: laravel/passport#1008

@johnson-jnr
Copy link

Hi @driesvints, is this issue still on? I'll really love to contribute.
Thanks!

@driesvints
Copy link
Member Author

driesvints commented Jan 20, 2020

@johnson-jnr yes :)

Probably best sent to master.

@Jimbolino
Copy link

Jimbolino commented Mar 15, 2020

i would advise against this.
comma seems to be more frequent than space:
(excuse my bad shell scripting skills)

jim@jim:~/socialiteproviders/providers/src$ ack scopeSeparator | grep "' '" | wc -l
32
jim@jim:~/socialiteproviders/providers/src$ ack scopeSeparator | grep "'+'" | wc -l
3
jim@jim:~/socialiteproviders/providers/src$ ack scopeSeparator | grep "';'" | wc -l
1
jim@jim:~/socialiteproviders/providers/src$ ack scopeSeparator | grep "','" | wc -l
2
jim@jim:~/socialiteproviders/providers/src$ ls -l | wc -l
163

163-32-3-1 = 127

source: https://github.com/SocialiteProviders/Providers/tree/master/src

@driesvints
Copy link
Member Author

I'm gonna close this because this isn't much of an issue really. Might not be worth the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants