Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.1] Deprecation message #566

Closed
robsontenorio opened this issue Dec 1, 2021 · 1 comment · Fixed by #567
Closed

[PHP 8.1] Deprecation message #566

robsontenorio opened this issue Dec 1, 2021 · 1 comment · Fixed by #567
Labels

Comments

@robsontenorio
Copy link

robsontenorio commented Dec 1, 2021

"php": "^8.1",
"laravel/framework": "^8.73",
"laravel/socialite": "^5.2"

Currently in socialite/src/AbstractUser.php. Probably other methods should be type hinted.

offsetExists()

PHP Deprecated:  Return type of Laravel\Socialite\AbstractUser::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/app/vendor/laravel/socialite/src/AbstractUser.php on line 146" 

offsetGet()

Return type of Laravel\Socialite\AbstractUser::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/app/vendor/laravel/socialite/src/AbstractUser.php on 

offsetSet()

Return type of Laravel\Socialite\AbstractUser::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/app/vendor/laravel/socialite/src/AbstractUser.php 

offsetUnset()

Return type of Laravel\Socialite\AbstractUser::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/app/vendor/laravel/socialite/src/AbstractUser.php on 
@driesvints
Copy link
Member

Thanks, I've sent in a PR for this: #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants