Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded path to vendor/composer in Console/TinkerCommand #25

Closed
DariusIII opened this issue Jul 27, 2017 · 4 comments
Closed

Hardcoded path to vendor/composer in Console/TinkerCommand #25

DariusIII opened this issue Jul 27, 2017 · 4 comments

Comments

@DariusIII
Copy link

DariusIII commented Jul 27, 2017 •
edited
Loading

Having hardcoded path prevents customizing folder structure, because tinker stops working if you change vendor_dir in composer.json file.

https://github.com/laravel/tinker/blob/master/src/Console/TinkerCommand.php#L57

Release 1.0.1 did not have this issue.
@GrahamCampbell
Copy link
Member

We'd be up for a PR to fix this. 👍

@dinhanhhuy
Copy link

same here, any 1 come up with a new pull request?

@DariusIII
Copy link
Author

I have created a PR: #26

@DariusIII
Copy link
Author

@taylorotwell closed the PR, so it is how it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GrahamCampbell @DariusIII @dinhanhhuy