Valet isolate proxy CLI commands do not respect custom site names #1272
Labels
Comments
|
Thanks, can you send in a PR? |
|
Hey @driesvints I can see a couple ways you could solve this - happy to try at a PR but just trying to work out what the best semantics would be, would using ie: |
|
Yes I think so 👍 |
aj-adl
added a commit
to framecreative/valet
that referenced
this issue
Aug 2, 2022
… commands Fixes laravel#1272 Adds support for passing in a custom sitename via the flag `--site=sitename` - Could be more flexible, at this point the '=' is mandatory - Code is repeated in two place, I thought it more likely that potential flags / checks diverge over time and didn't want to prematurely abstract Potential issues - someone calling a php command that requires a "--site" flag is not going to be able to pass it in. Other considerations - It would be better if the isolate function wasnt so tied to dir names - keeping a config file of isolated sites vs just parsing nginx configs seems better to me in the long run but is a larger and more serious refactor of valet. - We're a shop that uses valet for a lot of non-laravel stuff, and many legacy projects, so repo/folder names different to the domain is pretty common for us, less so for people on the golden path
aj-adl
added a commit
to aj-adl/valet
that referenced
this issue
Aug 2, 2022
Fixes laravel#1272 Adds support for passing in a custom sitename via the flag `--site=sitename` - Could be more flexible, at this point the '=' is mandatory - Command help updated, arguments added etc - Code is repeated in two place, I thought it more likely that potential flags / checks diverge over time and didn't want to prematurely abstract Potential issues - someone calling a php command that requires a "--site" flag is not going to be able to pass it in. Other considerations - It would be better if the isolate function wasn't so tied to dir names - keeping a config file of isolated sites vs just parsing nginx configs seems better to me in the long run but is a larger and more serious refactor of valet.
|
Going to close this as a PR was sent in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Firstly, I want to reiterate that the new features introduced in #1106 and #1216 are absolutely awesome, and have in general been a huge help.
This is really following on from #1206 - the PR there has fixed this issue for sites when running via FPM, but this fix doesn't carry over to the
valet phpandvalet composercommands.It's pretty easy to see how this has happened - if you look at
valet/valet
Line 92 in bc56e30
valet/valet
Line 85 in bc56e30
which-phpwithout any additional arguments, butwhich-phprequired the sitename to be passed in as an argument in order to work with domains that do not match the folder name.Steps To Reproduce:
Diagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
{ "tld": "test", "paths": [ "/Users/dev/.config/valet/Sites" ], "loopback": "127.0.0.1" }cat ~/.composer/composer.json
{ "require": { "laravel/valet": "^3.0", "squizlabs/php_codesniffer": "*", "wp-coding-standards/wpcs": "^2.1", "laravel/installer": "^4.0", "friendsofphp/php-cs-fixer": "^2.16", "beyondcode/expose": "^2.0" } }composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
PHP 8.1.3 (cli) (built: Mar 16 2022 04:10:24) (NTS) Copyright (c) The PHP Group Zend Engine v4.1.3, Copyright (c) Zend Technologies with Zend OPcache v8.1.3, Copyright (c), by Zend Technologieswhich -a php
php --ini
nginx -v
curl --version
php --ri curl
~/.composer/vendor/laravel/valet/bin/ngrok version
ls -al ~/.ngrok2
brew info nginx
brew info php
php: stable 8.1.8, HEAD General-purpose scripting language https://www.php.net/ /usr/local/Cellar/php/7.3.10.reinstall (519 files, 76.9MB) Built from source /usr/local/Cellar/php/7.4.8 (520 files, 76.1MB) Poured from bottle on 2020-07-15 at 10:01:36 /usr/local/Cellar/php/8.0.10.reinstall (497 files, 77.8MB) Built from source /usr/local/Cellar/php/8.1.3_1 (507 files, 79.9MB) * Built from source on 2022-03-16 at 14:41:12 From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/php.rb License: PHP-3.01 ==> Dependencies Build: httpd, pkg-config Required: apr, apr-util, argon2, aspell, autoconf, curl, freetds, gd, gettext, gmp, icu4c, krb5, libpq, libsodium, libzip, oniguruma, openldap, openssl@1.1, pcre2, sqlite, tidy-html5, unixodbc, libffi ==> Options --HEAD Install HEAD version ==> Caveats To enable PHP in Apache add the following to httpd.conf and restart Apache: LoadModule php_module /usr/local/opt/php/lib/httpd/modules/libphp.soFinally, check DirectoryIndex includes index.php
DirectoryIndex index.php index.html
The php.ini and php-fpm.ini file can be found in:
/usr/local/etc/php/8.1/
To restart php after an upgrade:
brew services restart php
Or, if you don't want/need a background service you can just run:
/usr/local/opt/php/sbin/php-fpm --nodaemonize
==> Analytics
install: 108,254 (30 days), 312,583 (90 days), 1,206,184 (365 days)
install-on-request: 92,769 (30 days), 267,594 (90 days), 1,025,490 (365 days)
build-error: 48 (30 days)
brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/usr/local/opt/php/sbin/php-fpm -v
PHP 8.1.3 (fpm-fcgi) (built: Mar 16 2022 04:10:27) Copyright (c) The PHP Group Zend Engine v4.1.3, Copyright (c) Zend Technologies with Zend OPcache v8.1.3, Copyright (c), by Zend Technologiessudo /usr/local/opt/php/sbin/php-fpm -y /usr/local/etc/php/8.1/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/usr/local/etc/nginx/valet/valet.conf\n---\n"; cat /usr/local/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
sh -c 'for file in ~/.config/valet/nginx/*; do echo "------\n~/.config/valet/nginx/$(basename $file)\n---\n"; cat $file | grep -n "# valet loopback"; echo "\n------\n"; done'
The text was updated successfully, but these errors were encountered: