Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Package laravel-vite-plugin files are inconsistent with this repo #168

Closed
ngstwr opened this issue Nov 18, 2022 · 4 comments
Closed
Labels

Comments

@ngstwr
Copy link

ngstwr commented Nov 18, 2022

  • Laravel Vite Plugin Version: 0.7.0
  • Laravel Version: 9.32
  • Node Version: 17.4.1
  • NPM Version: 8.19.2
  • Host operating system: macOS
  • Web Browser & Version: Chrome

Description:

The package installed via npm command doesn't have the latest version changes.

The added laravel-vite-plugin have the compiled index.js, which has following instead of what is supposed to be according to new version changelog:
manifest: !ssr

"Vite build" should create a custom-manifest.json file inside build directory, but it's still creating manifest.json.

This is the PR that was merged with the latest version:
#150

I checked the 'node_modules/laravel-vite-plugin/dist/index.js' inside my project directory, and found that it still has the old code:
manifest: !ssr

According to above PR and 'vite-plugin/blob/main/src/index.ts' file line number 127,
the compiled index.js is supposed to have following:
manifest: userConfig.build?.manifest ?? !ssr

Steps To Reproduce:

  1. Install laravel-vite-plugin on your project:
    yarn add laravel-vite-plugin -D

  2. On vite.config.js, change manifest file name to 'custom-manifest.json'
    build: {
    manifest: 'custom-manifest.json',
    }

  3. Build the application
    yarn prod

@driesvints
Copy link
Member

Okay I see it now. @jessarcher @timacdonald do you have any idea why the latest release doesn't have the correct files?

@driesvints driesvints added the bug label Nov 18, 2022
@ngstwr
Copy link
Author

ngstwr commented Nov 21, 2022

@driesvints @timacdonald

Is there any update on this?

People must have been getting the stale index.js for the last 25 days!

If someone can point out the cause, perhaps I can contribute!

@timacdonald
Copy link
Member

@ngstwr we are looking at it internally and will hopefully have it resolved shortly.

@timacdonald
Copy link
Member

We've just pushed a new version and my testing is now showing me that the expected files are on NPM. Closing this one, but let us know if you are still having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants