Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BrowserKit tests to HTTP tests #980

Closed
joedixon opened this issue Dec 13, 2023 · 3 comments
Closed

Migrate BrowserKit tests to HTTP tests #980

joedixon opened this issue Dec 13, 2023 · 3 comments

Comments

@joedixon
Copy link
Contributor

While the BrowserKit package is still maintained, it hasn't bee the default in Laravel for some time. It would be cool to port all the browser kit tests to HTTP tests and remove the laravel/browser-kit-testing dependency.

@digitlimit
Copy link
Contributor

@joedixon Since Laravel HTTP tests do not support tests like this (BrowserKit test).

test('users can manually subscribe to threads', function () {
    Thread::factory()->create(['slug' => $slug = $this->faker->slug()]);

    $this->login();

    $this->visit("/forum/$slug")
        ->press('Subscribe')
        ->seePageIs("/forum/$slug")
        ->see("You're now subscribed to this thread.");
});

I am wondering if you mean to port all BrowserKit to Laravel Dusk ?

@joedixon
Copy link
Contributor Author

joedixon commented Jan 9, 2024

Thanks for your interest @digitlimit, but I believe this one is already in the process of being tackled: #984

@digitlimit
Copy link
Contributor

@joedixon Thanks for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants