New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function Naming #3

Closed

uyab opened this issue Aug 25, 2016 · 2 comments

Assignees

Contributor

uyab commented Aug 25, 2016

Rename:

getProvinces()
getProvincesPaginate()
...

To:

allProvinces()
paginateProvinces()
...

This will make this package more consistent with Laravel, e.g: $model->all() and $model->paginate()

The text was updated successfully, but these errors were encountered:

Contributor Author

uyab commented Aug 25, 2016

And also:

getProvince($id) -> findProvince($id)
getCity($id) -> findCity($id)
....

adhatama self-assigned this

Contributor

adhatama commented Aug 25, 2016

Nice! I'm having a tough time figuring out the names before

adhatama closed this as completed in

1cf36fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment