Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably remove the unneeded random draw in APICaffe::ThreadFillerBase #37

Closed
twongjirad opened this issue May 29, 2016 · 3 comments
Closed
Assignees
Labels

Comments

@twongjirad
Copy link
Member

twongjirad commented May 29, 2016

Wouldn't consider it super urgent, though.

@twongjirad twongjirad added the bug label May 29, 2016
@twongjirad twongjirad changed the title Probably remove the unneeded random draw in ThreadFillerBase Probably remove the unneeded random draw in APICaffe::ThreadFillerBase May 29, 2016
@twongjirad
Copy link
Member Author

Or entry in process_entry( entry) should mean tree index. There is probably a reason why the different indexing is needed, though, that I fail to see.

@drinkingkazu
Copy link

I actually remembered why this feature exists: it is because "RandomAccess" configuration parameter is shared among ThreadDatumFiller and underlying IOManager (actually ProcessDriver, which owns IOManager). I'll change it such that ThreadDatumFiller creates its own IO configuration deterministically and never use RandomAccess (ThreadDatumFiller will decide randomness). This way index ThreadDatumFiller thinks = actual index in TTree.

@drinkingkazu
Copy link

Addressed: 29ea5ed

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants