Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paging to search UI #115

Closed
panmona opened this issue May 11, 2021 · 6 comments
Closed

Add paging to search UI #115

panmona opened this issue May 11, 2021 · 6 comments

Comments

@panmona
Copy link
Contributor

panmona commented May 11, 2021

When searching for movies only the first ~20 movies are shown. When your wished movie is not on that page, you can't add that movie. So I suggest to add paging like on themoviedb.
By the way: a filter like "release year" would be very nice to have.

Both of these features are supported by their API: https://developers.themoviedb.org/3/search/search-movies

@lardbit
Copy link
Owner

lardbit commented May 12, 2021

Good points! I guess I've never needed to page next on the search page. I like the release date filter as well. I'll keep this open until I have time to work on it.

@panmona
Copy link
Contributor Author

panmona commented May 12, 2021

I noticed this issue when I was trying to add the movie Burning.
Is there a way to manually circumvent this limitation for the time being?

@lardbit
Copy link
Owner

lardbit commented May 12, 2021

Yeah, a workaround is to just swap the tmdb id in the URL. So, just click on a random search result, and then swap the id in the URL. So, Burning has the tmdb id of 491584 so swap like:

image

@lardbit
Copy link
Owner

lardbit commented May 12, 2021

^ I got the tmdb id of Burning from the link you provided. It's in the URL.

@lardbit
Copy link
Owner

lardbit commented Jun 13, 2021

@panmau, I added paging to the Search screen. See f5d86ea. I'm closing this ticket but keep in mind it'll take an hour or so for the docker image to be built via Github Actions.

@lardbit lardbit closed this as completed Jun 13, 2021
@panmona
Copy link
Contributor Author

panmona commented Jun 16, 2021

Just checked it, thanks for adding it 👍
Would be even better if the current/previous/later pages could also be shown but that's just a nice to have and not really important. Time is better spent focusing on some other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants