Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with dev version of purrr #181

Merged
merged 5 commits into from Oct 5, 2022
Merged

Compatibility with dev version of purrr #181

merged 5 commits into from Oct 5, 2022

Conversation

larmarange
Copy link
Owner

@larmarange larmarange commented Oct 5, 2022

See tidyverse/purrr#969

  • Remove Remotes field in DESCRIPTION before merging

@larmarange larmarange marked this pull request as draft October 5, 2022 07:08
@larmarange larmarange marked this pull request as ready for review October 5, 2022 07:24
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #181 (a32e76f) into main (3cdccea) will increase coverage by 1.35%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   97.34%   98.70%   +1.35%     
==========================================
  Files          38       38              
  Lines        1694     1695       +1     
==========================================
+ Hits         1649     1673      +24     
+ Misses         45       22      -23     
Impacted Files Coverage Δ
R/assert_package.R 94.02% <100.00%> (+34.93%) ⬆️

@larmarange
Copy link
Owner Author

The checks failed with R 3.6 on Windows but it could be due to the fact that the remotes version of purrr is not available.

We need to re-check once the Remotes filed removed from DESCRIPTION.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! once this is merged, i'll work on gtsummary too

@larmarange
Copy link
Owner Author

Thanks. Let me remove the Remotes from the DESCRIPTION, re-run all checks and then merge.

We may submit a new version on CRAN just after, what do you think?

@larmarange larmarange merged commit 5a617bc into main Oct 5, 2022
@ddsjoberg
Copy link
Collaborator

We may submit a new version on CRAN just after, what do you think?

I looked in the purrr code and it seems to be a soft deprecation, meaning that warnings only appear in dev environments. So I don't there is any rush to release before their purrr 1.0 release

@larmarange larmarange deleted the compat_purrr branch October 5, 2022 15:35
@larmarange
Copy link
Owner Author

It could be a problem for purrr team as CRAN will run a revdep check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants