-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work when app not available on the US App Store #16
Comments
@skol101 I assume the iTunes API is returning an empty response when the app is not available on the US App Store. In that case, there is no version of the app to upgrade, and thus there should not be a message or alert displayed to the user. Can you explain more about your issue, including the messages from the log, and possibly any screenshots? |
The issue is that the plugin or iTunes Api call doesn't check whether app is available on other markets. For instance, if I just open https://apps.apple.com/app/id1478293930 in the browser, the App Store will open even when the app isn't available on the US app store. |
What country codes are valid for the 1478293930 app? |
We've made it available in the US with the recent update, though not in Russia ('ru' I believe). |
This package is not designed to handle App Stores outside of US. However, it may not be that difficult to add country support. The URL used by the iTunes class is:
This URL https://itunes.apple.com/lookup?id=1478293930&country=CA seems to return the Canadian store listing. I may be able to get the store country ID from a plugin and use that in the URL. Let me look into that. |
Hi, Thanks, |
@hivesey This package does not support multiple countries for iOS. It only supports the US app store at this time. However, there is a quick patch you could make if you want to support only one country that is not US. To make that patch, fork this repo, and change the following line to the country code of your choice: upgrader/lib/src/upgrader.dart Line 147 in a22e996
|
Any lookup (by id, by app bundle id) returns null if the app isn't available on the US App Store.
Please, fix or suggest a workaround.
The text was updated successfully, but these errors were encountered: