Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior on Android is different from specified in Readme #55

Closed
apripy opened this issue Aug 24, 2020 · 2 comments
Closed

Behavior on Android is different from specified in Readme #55

apripy opened this issue Aug 24, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@apripy
Copy link

apripy commented Aug 24, 2020

According to the Readme:

On Android, this widget does nothing as there is no easy way to query the Google Play Store for metadata about an app. Without the metadata, the widget cannot compare the app version with the latest Play Store version. It will not disrupt the widget tree and can be included in an Android without any issues.

However, in my application (not using an Appcast) the upgrader popup was shown to Android users, redirecting them to the AppStore. Looking at the code, it seems like the check has been commented:

//      // If this platform is not iOS, skip the iTunes lookup
//      if (!Platform.isIOS) {
//        return false;
//      }
@larryaasen
Copy link
Owner

Thanks for pointing out this issue. I was not able to reproduce the popup on Android because _appStoreVersion and _appStoreListingURL are null, which means isUpdateAvailable() will return false. However, the Android package name was 'com.larryaasen.upgraderexample' in the Android example app, and was not 'com.google.maps' like in the iOS example app. When the Android package name matched a valid bundle ID for iOS, this error would happen. I am working on a fix now.

@larryaasen larryaasen self-assigned this Aug 25, 2020
@larryaasen larryaasen added the bug Something isn't working label Aug 25, 2020
@larryaasen
Copy link
Owner

I just published version 2.5.1 of this package with a fix for this issue. Please try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants