Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion Rate: NaN% when using stats command on an empty ProfPlan #5

Open
larrywang0701 opened this issue Nov 17, 2023 · 1 comment

Comments

@larrywang0701
Copy link
Owner

larrywang0701 commented Nov 17, 2023

How to reproduce:

  • First run clear or delete all to get an empty ProfPlan
  • Then run stats
    Will get:
Here are your statistics Prof!
Completion Rate: NaN%

Which the completion rate is not meaningful under this context. Maybe in the application internal somewhere is divided by zero (total task number)?

image.png

@nus-se-script
Copy link

nus-se-script commented Nov 20, 2023

Team's Response

The reported issue regarding the stats command displaying Completion Rate: NaN% on an empty ProfPlan has been carefully reviewed. We decide to reject this bug report.

We assert that this behavior is not a bug but a deliberate design choice. The target audience, CS professors, possess a strong understanding of NaN and its significance in computations. Displaying 0% could mislead them as it inaccurately represents the context where division by zero (0/0) occurs.

Retaining NaN% serves a purpose, ensuring accuracy and relevance for our intended users. Therefore, we respectfully disagree with categorizing this behavior as a bug.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Thanks for the team's reply.

But for (0/0) occurs, why not display a string telling the user "the ProfPlan is empty" or something, instead must use a "NaN" which may confuse the user? It seems that the team is giving their explaination of rejection based on the developers' view, that they know NaN is caused by 0/0. But how would the developers expect the user to "think" or "guess" the correct meaning of NaN by themselves? If I'm a user, when I see NaN (not a number), I may easily think the application is bugged instead of thinking the application is "very accurate" before I think and realize the 0/0 division.

Thanks!


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants