RevMob adapter - full width landscape

[Fred10932]

I have Revmob working (with AdMob as backup) using below methods, but using the same width for landscape as portrait. If anyone knows a solution, that would be great.

- (RevMobBannerView *)bannerView{
if (_bannerView == nil && _publisherId) {
    [RevMobAds startSessionWithAppID:_publisherId];

    //[RevMobAds session].testingMode = RevMobAdsTestingModeWithoutAds;

    _bannerView = [[RevMobAds session] bannerView];
    _bannerView.delegate = self;
    [_bannerView loadAd];

    // Couldn't get layoutBannerForInterfaceOrientation method working, used this solution for now:

    if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) {
        _bannerView.frame = CGRectMake(0, 0, 768, 90);
      } else {
        _bannerView.frame = CGRectMake(0, 0, 320, 40);
    }
    [self.bannerView setNeedsLayout];
}
else if(!_publisherId){
    NSLog(@"RevMob Publisher ID not set. No ads will be served until you set one using %@ on %@!", NSStringFromSelector(@selector(registerAdClass:withPublisherId:)),NSStringFromClass([LARSAdController class]));
}
return _bannerView;
}

#pragma mark - Required RevMob methods

-(void)revmobAdDidFailWithError:(NSError *)error {
NSLog(@"Ad failed with error: %@", error);
if ([self.adManager respondsToSelector:@selector(adFailedForNetworkAdapterClass:)]) {
    [self.adManager adFailedForNetworkAdapterClass:[self class]];
}
}

-(void)revmobAdDidReceive {
NSLog(@"Ad loaded successfullly");
if ([self.adManager     respondsToSelector:@selector(adSucceededForNetworkAdapterClass:)]) {
    [self.adManager adSucceededForNetworkAdapterClass:[self class]];
}
}

-(void)revmobAdDisplayed {
NSLog(@"Ad displayed");

}

-(void)revmobUserClickedInTheAd {
NSLog(@"User clicked in the ad");
}

-(void)revmobUserClosedTheAd {
NSLog(@"User closed the ad");
}

[larsacus]

Do you have this in a branch I can clone and try out?

[larsacus]

Is this the full implementation of the adapter? Or is there a branch I can try out?

[Fred10932]

Hi Lars
Sorry was out for the weekend. I have a branch ready but need collaborator status to upload.

[larsacus]

If you have a fork of the project, you can push the branch up to your own fork.

[Fred10932]

OK -- see RevMob branch @ https://github.com/Fred10932/LARSAdController.git

[larsacus]

I guess I'm really not sure what the specific issue is, but I did clean it up a bit. Check out my RevMob branch.

I'm not sure what it's supposed to look like in landscape as right now all it does is stretch the test ad.

[Fred10932]

Thanks. I also tested some live banners with your solution and indeed RevMob (there are only a few varieties) doesn't adapt its banners to more screen real estate, they just stretch out.
I think constraining the banner to a 320 (iPhone) or 768 (iPad) width may be the way to go for this adapter after all.