Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to be more Nodejs-like #31

Closed
larsgw opened this issue Mar 16, 2017 · 1 comment
Closed

Refactor code to be more Nodejs-like #31

larsgw opened this issue Mar 16, 2017 · 1 comment
Assignees
Labels
refactor Requests not impacting main APIs
Projects

Comments

@larsgw
Copy link
Owner

larsgw commented Mar 16, 2017

Currently, all the source code (minus dependencies) is in one file. This is because, previously, that one file was used in the browser as well. Now that we have a browserify bundle (see #24), this isn't necessary anymore, and code should be split up into different files.

Also, I followed an... ehmm... unusual coding convention when I (re)wrote the source code in v0.2. I'll fix that too.

Some other expected improvements:

@larsgw larsgw added refactor Requests not impacting main APIs enhancement Feature requests labels Mar 16, 2017
@larsgw larsgw self-assigned this Mar 16, 2017
@larsgw larsgw added this to In Progress in Version 0.3 Mar 16, 2017
@larsgw
Copy link
Owner Author

larsgw commented Apr 3, 2017

Edit: The following aspect is now handled by #38

This probably includes using more recent ECMAScript features like const, let, arrow functions, template strings, Array#map() (and other array and object methods) etc. These can be parsed for browsers with https://github.com/babel/babelify (or maybe something similar).

@larsgw larsgw moved this from In Progress to TODO in Version 0.3 Apr 7, 2017
@larsgw larsgw removed the enhancement Feature requests label Apr 17, 2017
@larsgw larsgw moved this from TODO to In Progress in Version 0.3 Apr 30, 2017
@larsgw larsgw closed this as completed in 0f18768 May 8, 2017
@larsgw larsgw moved this from In Progress to Done in Version 0.3 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Requests not impacting main APIs
Projects
No open projects
Development

No branches or pull requests

1 participant