Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose parseInput via Cite #34

Closed
larsgw opened this issue Mar 31, 2017 · 1 comment
Closed

Expose parseInput via Cite #34

larsgw opened this issue Mar 31, 2017 · 1 comment
Assignees
Labels
enhancement Feature requests refactor Requests not impacting main APIs
Projects

Comments

@larsgw
Copy link
Owner

larsgw commented Mar 31, 2017

Expose the currently private parseInput method on Cite, and change the way Wikidata ID strings are parsed. This should make writing test cases (#22) and async parsing (#29) easier.

@larsgw larsgw self-assigned this Apr 3, 2017
@larsgw larsgw added the refactor Requests not impacting main APIs label Apr 3, 2017
@larsgw
Copy link
Owner Author

larsgw commented Apr 3, 2017

The new structure will expose the chainlink way of parsing better, for mainly testing. Currently, the structure is this:

1: parseInput ---> 2: parseInputType ---> 3: parseInputData ---> 4a: repeat from step 1
                                                             \-> 4b: return data

A better way would be to have a while loop in parseInput() that repeats parseInputType() parseInputData() until the wanted format is achieved. These can then all be individually tested and used.

@larsgw larsgw added this to In Progress in Version 0.3 Apr 3, 2017
@larsgw larsgw moved this from In Progress to TODO in Version 0.3 Apr 7, 2017
@larsgw larsgw added the enhancement Feature requests label Apr 7, 2017
@larsgw larsgw moved this from TODO to In Progress in Version 0.3 Apr 8, 2017
@larsgw larsgw closed this as completed in e94d27a Apr 9, 2017
@larsgw larsgw moved this from In Progress to Done in Version 0.3 Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests refactor Requests not impacting main APIs
Projects
No open projects
Development

No branches or pull requests

1 participant