Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions #2053

Closed
larshp opened this issue Nov 6, 2018 · 2 comments
Closed

Naming conventions #2053

larshp opened this issue Nov 6, 2018 · 2 comments
Assignees
@larshp

Comments

@larshp
Copy link
Member

larshp commented Nov 6, 2018 

/zcl_abapgit_branch_overview.clas.abap[61, 17]            - Bad method parameter name "itr_commit_sha1s" expected "^I._.*$"
/zcl_abapgit_branch_overview.clas.abap[62, 17]            - Bad method parameter name "etr_commit_sha1s" expected "^E._.*$"
/zcl_abapgit_branch_overview.clas.abap[63, 17]            - Bad method parameter name "e_1st_commit" expected "^E._.*$"
/zcl_abapgit_objects.clas.abap[52, 9]                     - Bad method parameter name "i_line_number" expected "^I._.*$"
/objects/zcl_abapgit_objects_saxx_super.clas.abap[37, 11] - Bad method parameter name "p_data" expected "^E._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[13, 19]      - Bad method parameter name "i_obj_name" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[14, 19]      - Bad method parameter name "i_obj_type" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[15, 19]      - Bad method parameter name "i_sub_obj_name" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[16, 19]      - Bad method parameter name "i_sub_obj_type" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[17, 19]      - Bad method parameter name "i_line_number" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[77, 11]      - Bad method parameter name "i_obj_name" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[78, 11]      - Bad method parameter name "i_obj_type" expected "^I._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[82, 11]      - Bad method parameter name "e_program" expected "^E._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[83, 11]      - Bad method parameter name "e_include" expected "^E._.*$"
/objects/zcl_abapgit_object_msag.clas.abap[38, 11]        - Bad method parameter name "i_message_id" expected "^I._.*$"
/ui/zcl_abapgit_gui_page_codi_base.clas.abap[13, 31]      - Bad method parameter name "ro_html" expected "^I._.*$"
/ui/zcl_abapgit_gui_page_codi_base.clas.abap[19, 11]      - Bad method parameter name "i_line_number" expected "^I._.*$"
@larshp larshp self-assigned this Nov 7, 2018
larshp added a commit that referenced this issue Nov 7, 2018
@larshp
naming conventions #2053
7cbd7bc
@larshp larshp mentioned this issue Nov 7, 2018
Merged
larshp added a commit that referenced this issue Nov 7, 2018
@larshp
naming conventions #2053
788a7fe
@larshp larshp mentioned this issue Nov 7, 2018
Merged
larshp added a commit that referenced this issue Nov 7, 2018
@larshp
Naming conventions fixes, #2053 (#2058)
89e5010 
* fix more naming conventions

* more naming conventions fixes
@larshp
Copy link
Member Author

larshp commented Nov 7, 2018

todo,

/zcl_abapgit_branch_overview.clas.abap[157, 20]                 - Bad local variable name "deleted_branch_info" expected "^L._.*$"
/zcl_abapgit_branch_overview.clas.abap[478, 11]                 - Bad local variable name "lsr_parent" expected "^L._.*$"
/zcl_abapgit_branch_overview.clas.abap[479, 11]                 - Bad local variable name "ltr_commit_sha1s" expected "^L._.*$"
/zcl_abapgit_branch_overview.clas.abap[480, 20]                 - Bad local variable name "<lsr_commit_sha1>" expected "^<L._.*>$"
/zcl_abapgit_branch_overview.clas.abap[531, 11]                 - Bad local variable name "ltr_parents" expected "^L._.*$"
/zcl_abapgit_branch_overview.clas.abap[532, 11]                 - Bad local variable name "lsr_parent" expected "^L._.*$"
/zcl_abapgit_folder_logic.clas.abap[59, 11]                     - Bad local variable name "st_parent" expected "^L._.*$"
/zcl_abapgit_objects.clas.abap[707, 11]                         - Bad local variable name "object" expected "^L._.*$"
/zcl_abapgit_repo_content_list.clas.abap[107, 11]               - Bad local variable name "item" expected "^L._.*$"
/zcl_abapgit_tadir.clas.abap[54, 11]                            - Bad local variable name "last_package" expected "^L._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[66, 25]            - Bad method parameter name "e_active" expected "^R._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[75, 25]            - Bad method parameter name "r_is_adt_jump_possible" expected "^R._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[275, 11]           - Bad local variable name "messages" expected "^L._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[276, 11]           - Bad local variable name "e071_tadirs" expected "^L._.*$"
/objects/zcl_abapgit_objects_super.clas.abap[277, 11]           - Bad local variable name "e071_tadir" expected "^L._.*$"
/objects/zcl_abapgit_object_scp1.clas.abap[86, 10]              - Bad local variable name "profile_type" expected "^L._.*$"
/objects/zcl_abapgit_object_scp1.clas.abap[87, 10]              - Bad local variable name "fatherprofiles" expected "^L._.*$"
/objects/zcl_abapgit_object_scp1.clas.abap[88, 10]              - Bad local variable name "fatherprofile" expected "^L._.*$"
/objects/zcl_abapgit_object_scp1.clas.abap[273, 11]             - Bad local variable name "profile_id" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[20, 50]              - Bad method parameter name "e_range_node_codes" expected "^R._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[136, 11]             - Bad local variable name "range_node_code" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[158, 10]             - Bad local variable name "element" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[159, 10]             - Bad local variable name "leading_spaces" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[160, 10]             - Bad local variable name "coding_line" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[181, 11]             - Bad local variable name "element" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[182, 11]             - Bad local variable name "code_line" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[183, 11]             - Bad local variable name "offset" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[257, 11]             - Bad local variable name "within_code_section" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[338, 11]             - Bad local variable name "ssfo_formname" expected "^L._.*$"
/objects/zcl_abapgit_object_ssfo.clas.abap[430, 11]             - Bad local variable name "within_code_section" expected "^L._.*$"
/objects/zcl_abapgit_object_udmo.clas.abap[415, 19]             - Bad local variable name "<udmo_entity>" expected "^<L._.*>$"
/objects/zcl_abapgit_object_xinx.clas.abap[87, 11]              - Bad local variable name "rc" expected "^L._.*$"
/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap[109, 20] - Bad local variable name "<ecatt_object>" expected "^<L._.*>$"
/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap[46, 20]    - Bad local variable name "<ecatt_object>" expected "^<L._.*>$"
/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap[98, 20]    - Bad local variable name "<ecatt_sp>" expected "^<L._.*>$"
/ui/zcl_abapgit_popups.clas.abap[315, 11]                       - Bad local variable name "struct_descr" expected "^L._.*$"
/utils/zcl_abapgit_convert.clas.abap[53, 11]                    - Bad local variable name "bitbyte" expected "^L._.*$"
/utils/zcl_abapgit_convert.clas.abap[54, 11]                    - Bad local variable name "len" expected "^L._.*$"
/utils/zcl_abapgit_convert.clas.abap[55, 11]                    - Bad local variable name "offset" expected "^L._.*$"

@larshp larshp mentioned this issue Nov 7, 2018
Merged
@larshp
Copy link
Member Author

larshp commented Nov 7, 2018

todo,

/zcl_abapgit_object_ssfo.clas.abap[20, 50]  - Bad method parameter name "e_range_node_codes" expected "^R._.*$"
/zcl_abapgit_object_ssfo.clas.abap[136, 11] - Bad local variable name "range_node_code" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[158, 10] - Bad local variable name "element" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[159, 10] - Bad local variable name "leading_spaces" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[160, 10] - Bad local variable name "coding_line" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[181, 11] - Bad local variable name "element" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[182, 11] - Bad local variable name "code_line" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[183, 11] - Bad local variable name "offset" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[257, 11] - Bad local variable name "within_code_section" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[338, 11] - Bad local variable name "ssfo_formname" expected "^L._.*$"
/zcl_abapgit_object_ssfo.clas.abap[430, 11] - Bad local variable name "within_code_section" expected "^L._.*$"

@larshp larshp mentioned this issue Nov 7, 2018
Merged
@larshp larshp closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larshp larshp

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@larshp