Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and enhance OTR support #3681

Merged
merged 8 commits into from Aug 9, 2020
Merged

Refactor and enhance OTR support #3681

merged 8 commits into from Aug 9, 2020

Conversation

mbtools
Copy link
Member

@mbtools mbtools commented Jul 29, 2020

  • Texts were missing if more than one concept existed per WebDynpro component or exception class. Also fixes unit tests that were not working properly before and adds one new test.
  • Now supports all objects that use OTR: CLAS (LIMU/CPUB), ENHC, ENHO, ENHS, ENSC, WAPA (LIMU/WAPP) WDYA, WDYN (LIMU/WDYV), WEBI

Note: Many diffs are due to reorder of method implementation. The change is actually resulting in a much cleaner implementation for SOTR in zcl_abapgit_sotr_handler=>create/read_sotr.

Texts were missing if more than one concept existed per WebDynpro component. Also fixes unit tests which were not working properly before and adds anew test.
Now supports all objects that use OTR: CLAS (LIMU/CPUB), ENHC, ENHO, ENHS, ENSC, WAPA (LIMU/WAPP) WDYA, WDYN (LIMU/WDYV), WEBI
Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants