Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Obsidian 1.0.0 Support #1

Merged
merged 2 commits into from Oct 15, 2022
Merged

feat: Obsidian 1.0.0 Support #1

merged 2 commits into from Oct 15, 2022

Conversation

larsmagnus
Copy link
Owner

Description of the Change

  • Move button settings to a constant
  • Simplifies the event listener for panel button clicks
  • Explicitly set the custom CSS variables for text colours as they've been moved for Obsidian 1.0.0
  • Adds more comments
  • Only support Obsidian 1.0.0 and up
  • Cleans up unused ´getAppTheme´

Checklist

  • Used the provided eslint configuration, as explained in the Readme.
  • Did not use prettier.
  • Used expressive variable names.
  • Code is commented well.

@larsmagnus
refactor: simplify settings and event listener
e25592e 
- toggle the theme on the leaf container node parent to ensure correct styling with v1.0.0 tabs
- moves button settings to a constant
- don't delete persisted data when de-activating the plugin
- removes unused getAppTheme
- adds more comments
@larsmagnus
feat: ensure theme styling works with 1.0
7917820 
- updates plugin to 1.0.1
@larsmagnus larsmagnus self-assigned this Oct 15, 2022
@larsmagnus larsmagnus merged commit 0370bf3 into main Oct 15, 2022
@larsmagnus larsmagnus deleted the feat/obsidian-1-support branch October 15, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsmagnus larsmagnus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@larsmagnus