Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing "Source Control" menu #24

Open
noahemmet opened this issue Apr 23, 2015 · 3 comments
Open

Use existing "Source Control" menu #24

noahemmet opened this issue Apr 23, 2015 · 3 comments

Comments

@noahemmet
Copy link

Instead of creating a new "Github" menu bar item, the plug-in should use the pre-existing "Source Control" menu (maybe with a "Github" submenu). A whole new menu item with only two entries takes up a lot of precious menu real estate.

@noahemmet noahemmet changed the title Should use existing "Source Control" menu Use existing "Source Control" menu Apr 23, 2015
@larsxschneider
Copy link
Owner

Hi,

thanks for the suggestion. @mabedan did that already:
#18

However, I wonder if and how we should tell people about the change. Otherwise they might feel confused because their Github menu is gone?

Would you be willing to pick you the existing PR and add some welcome message?

Cheers,
Lars

@noahemmet
Copy link
Author

Hmm, I suppose people might get a little confused, but I don't think a popup message is a good solution—it interrupts a user's workflow and I'd be pretty annoyed if plugins started popping up alerts when I launch Xcode. And really, the Source Control menu is a pretty intuitive place to look for github-related features.

You could change the text in the Alcatraz blurb to "Open the related Github page of a source file directly from the Source Control menu in Xcode", which would go a long way. Also, users can always search directly for specific menu items via the Help > Search menu item.

Nice job with the plugin so far!

@cbowns
Copy link

cbowns commented Apr 19, 2016

+1 for this change. And no, I don't think any migration is necessary: I imagine most users are using the keyboard shortcut; and I think adding a menu item (to the eleven already present!) is wasteful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants