Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bitbucket #9

Merged
merged 2 commits into from
Sep 11, 2013
Merged

Conversation

payliu
Copy link
Contributor

@payliu payliu commented Sep 2, 2013

Do not change any menu name, just open last commit or file at Bitbucket.org according to its repo name. issue #8.

@payliu payliu mentioned this pull request Sep 2, 2013
(unsigned long)fileNumber,
commitLine];

} else {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check for bitbucket repo here?

@larsxschneider
Copy link
Owner

Hi @payliu !

Very nice work! Thank you very much. I made a few remarks and I am happy to merge it!

@payliu
Copy link
Contributor Author

payliu commented Sep 9, 2013

hi @larsxschneider,

I finish to modify. It will check isBitBucketRepo.

And also check github.org, github.com, bitbucket.org and bitbucket.com.

If not isGithubRepo and isBitBucketRepo, it will do nothing.

Thanks:)

@larsxschneider larsxschneider merged commit 8d5086b into larsxschneider:master Sep 11, 2013
@larsxschneider
Copy link
Owner

@payliu I merged your PR with a few modifications. I really need to support github enterprise instances (that's what I use daily) and there is no easy way to detect these kind of servers because they can have arbitrary URLs. Can you check if the bitbucket stuff still works for you? Again, thanks a lot for the PR!

@payliu
Copy link
Contributor Author

payliu commented Sep 13, 2013

@larsxschneider , no problem. :)

I'm not sure what's mean of about arbitrary URLs that you said.
And I do not have that experience of github enterpise instance.

What the url you meet is
git clone https://repo.company.com/John/GoodStuff.git
or
git clone git@repo.company.com.com:John/GoodStuff.git

And we should make ShowInGitHub to know that?

@payliu
Copy link
Contributor Author

payliu commented Sep 22, 2013

@larsxschneider, sorry late, it can work well in Bitbucket. thanks.

@larsxschneider
Copy link
Owner

great 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants