Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon displayed #29

Open
sabian2008 opened this issue Oct 22, 2017 · 9 comments
Open

No icon displayed #29

sabian2008 opened this issue Oct 22, 2017 · 9 comments

Comments

@sabian2008
Copy link

Hi

I'm in a fresh Fedora 27 installation (Gnome 3.26) and, although the extension works fine, it only adds an empty space (which is clickable and it works!) to the menu.

Any ideas on where to start looking for errors?

Cheers,

@Naheel-Azawy
Copy link

It's because of the last update. Find the following line on extension.js:

this._altsuspendAction = this.systemMenu._createActionButton('system-suspend-symbolic', _("Suspend"));

and replace it with:

this._altsuspendAction = this.systemMenu._createActionButton('media-playback-pause-symbolic', _("Suspend"));

This is happening because not all icon packs provide 'system-suspend-symbolic'

@sabian2008
Copy link
Author

Thanks a lot, worked like a charm.

Really nice extension, it's a must (and I use very few extensions!).

Cheers,

@jackpot51
Copy link
Contributor

Perhaps it would be best if the icon were configurable.

@Naheel-Azawy
Copy link

Or even better, automatically figure out which icon can be used.
Too lazy to dig more in the gjs docs. Dev, can you please :)

@laserb
Copy link
Owner

laserb commented Oct 23, 2017

I think having system-suspend as default and the old one as fallback is a good solution. I will look into that.

@laserb
Copy link
Owner

laserb commented Oct 24, 2017

I changed it back to the old icon for now.

@ddnexus
Copy link

ddnexus commented Oct 25, 2017

About the system suspend as default: the new icon could be present but could have nothing to do with the style in the set that the shell theme is using (maybe due to icon-fallback?). In my case, while the old icon was totally consistent with the other icon used in the other buttons, the new one is not. That should be taken into consideration as well.

@genodeftest
Copy link

@jackpot51

Perhaps it would be best if the icon were configurable.

I don't think this is useful.

@jackpot51
Copy link
Contributor

@genodeftest I don't mind it going back to the pause button if that fixes problems - I am using a fork with my preferred icon anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants