Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] SVGs not resizing in IE11 #51

Open
thejettdurham opened this issue Sep 22, 2020 · 0 comments
Open

[Regression] SVGs not resizing in IE11 #51

thejettdurham opened this issue Sep 22, 2020 · 0 comments

Comments

@thejettdurham
Copy link

We generate SVG avatars with a single size in the backend, and then use width and height attributes of the img tag to size them as-needed on the frontend. On the latest release, this works fine in all oses/browsers except for Internet Explorer 11.

bad example 100x100

bad example 52x49

When we downgrade to 4.1.1, they look (somewhat) as expected in IE 11

good example 100x100

good example 52x49

To be clear, they don't look great in IE 11, but at least they're readable 😂

We are okay to stay on version 4.1.1 for the time being, as our use-case doesn't expose the Firefox bug that was fixed in 4.1.2. But, since our team is committed to IE 11 support throughout its remaining support lifespan, it would be nice to see this addressed somehow in the library.

It looks like adding the viewBox attribute to the root SVG element would potentially fix the issue. So perhaps it could be added internally upon generation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant