Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting arguments of pretraining by a config file #22

Merged
merged 9 commits into from Nov 28, 2021
Merged

Support setting arguments of pretraining by a config file #22

merged 9 commits into from Nov 28, 2021

Conversation

seopbo
Copy link
Member

@seopbo seopbo commented Nov 28, 2021 •
edited

  • config 파일하나로 pretrain_language_model.py에 실행에 필요한
    arguments를 전달함.
  • nested dict 처리를 위한 Omegaconf library 추가
  • CONFIG_MAPPING을 활용하여 class 생성자 호출

Refs: #16

alex and others added 5 commits November 26, 2021 17:57
[Python] feat: Append ignore pycharm idea dir
ce1902f 
- PyCharm IDEA 디렉토리 ignore

Refs: #16
[Git] feat: Append ignore pycharm idea dir
be22a03 
- PyCharm IDEA 디렉토리 ignore

Refs: #16
Merge branch 'feature/#16' of https://github.com/lassl/lassl into fea…
b613f37 
…ture/#16
Merge branch 'main' into feature/#16
c77f871
@seopbo
[mixed] refactor: Configs for a pretrain script
29d71ae 
- config 파일하나로 pretrain_language_model.py에 실행에 필요한
  arguments를 전달함.
- nested dict 처리를 위한 Omegaconf library 추가

Refs: #16
monologg
monologg reviewed Nov 28, 2021
View reviewed changes
.gitignore Show resolved Hide resolved
monologg
monologg approved these changes Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@monologg monologg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iron-ij
iron-ij reviewed Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@iron-ij iron-ij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample 수준의 config 파일이라도 같이 포함되어야 할 것 같습니다. 아까 만드셨던 거라도 더해주시면 좋을 것 같아요~!!

@seopbo
Copy link
Member Author

seopbo commented Nov 28, 2021

sample 수준의 config 파일이라도 같이 포함되어야 할 것 같습니다. 아까 만드셨던 거라도 더해주시면 좋을 것 같아요~!!

@iron-ij 아 그거 추가되어있을텐데요??

@seopbo
Copy link
Member Author

seopbo commented Nov 28, 2021

sample 수준의 config 파일이라도 같이 포함되어야 할 것 같습니다. 아까 만드셨던 거라도 더해주시면 좋을 것 같아요~!!

@iron-ij 아 그거 추가되어있을텐데요??

없는 거 확인하고 추가했습니다.

bzantium
bzantium reviewed Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@bzantium bzantium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model_type의 가능 범주를 알려주는 조건절 명령어 추가

pretrain_language_model.py Outdated Show resolved Hide resolved
@seopbo @bzantium
Update pretrain_language_model.py
b5bab1e 
Co-authored-by: Minho Ryu <ryumin93@gmail.com>
bzantium
bzantium approved these changes Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@bzantium bzantium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@seopbo seopbo merged commit 8a12a37 into main Nov 28, 2021
@seopbo seopbo deleted the feature/#16 branch November 28, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monologg monologg monologg approved these changes

@iron-ij iron-ij iron-ij left review comments

@bzantium bzantium bzantium approved these changes

@alxiom alxiom Awaiting requested review from alxiom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seopbo @bzantium @monologg @iron-ij