Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html_header update #337

Open
torvista opened this issue Mar 14, 2024 · 2 comments
Open

html_header update #337

torvista opened this issue Mar 14, 2024 · 2 comments
Labels
question A question about the template

Comments

@torvista
Copy link

I'll note there are a lot of differences between BS and ZC version of this file at the moment, making merging/comparing more onerous than necessary.
I'd suggest the ZC file gets a spring clean before release to make things easier.

@lat9
Copy link
Owner

lat9 commented Mar 14, 2024

Yep, since the Bootstrap template is its own entity, I've got more "freedom" to do those reformatting/refactoring exercises. Noting that this issue should be raised on the Zen Cart GitHub, because I'm not planning on taking the template backwards.

@lat9 lat9 added the question A question about the template label Mar 14, 2024
@torvista
Copy link
Author

Since I don't think anything actually needs fixing, I don't think it is normally justified to rework a core file for no concrete reason.

But since core files are the starting point, and changes need propagating to user templates, having a plugin file with many sections "more-advanced" (cosmetically) than a core file is cart before the horse and leads to people making decision...is this important or not etc.

Maybe there should be more flexibility/consideration/encouragement allowed for this situation: if someone is working on a plugin that enhances core, cosmetic changes to core should be allowed to facilitate that, to provide an "updated" base.

Which is a corollary of my point of view that any contribution to the core however minor should be allowed/encouraged as that can only lead to more and better input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question A question about the template
Projects
None yet
Development

No branches or pull requests

2 participants