Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect total price in attributes when first added, before clicking update #79

Closed
lankeeyankee opened this issue May 16, 2018 · 4 comments

Comments

@lankeeyankee
Copy link

If you add an item with attributes that are either on sale/special or for some other reason are priced by 4 decimals in the DB and add enough quantity it will at first display an incorrect total price until the update button is clicked.

Example: item is 5.99 priced by attribute, apply a 5% sale, the new price is $5.6905 which is correctly displayed as $5.69, add 10 through the add product funtion and the total price shows as $56.91 when you come back to the main page. Once you click update it correctly changes the total to $56.90.

Just a small thing that can be confusing as well as cause errors. If you are adding an order comment saying what is added/subtracted/changed plus the total you might be off from the actual total.

@lat9 lat9 added the bug label May 16, 2018
@lat9 lat9 added this to the v5.0.0 milestone May 16, 2018
@lat9
Copy link
Owner

lat9 commented May 16, 2018

That's a "known issue" with the current Edit Orders v4 implementation. I'm working on a 5.0.0 release that should correct this.

@lankeeyankee
Copy link
Author

Great, thanks!!

@lat9 lat9 modified the milestones: v5.0.0, v4.4.0 May 18, 2019
@lat9
Copy link
Owner

lat9 commented May 18, 2019

Just validated that the various changed made for EO 4.4.0 (currently on the pricing_fixups branch) in the "rounding" area appear to have corrected this issue.

@lankeeyankee
Copy link
Author

Fantastic, thanks so much!!

@lat9 lat9 closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants