New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct unicode value of \=y #326
Conversation
Looks good to me. I would agree an entry in ltnews isn't needed, and I doubt there's much benefit to a test file here (?). So I would say good to go. |
Oh, Ulrike if you leave out the space in |
base/changes.txt
Outdated
@@ -1,4 +1,9 @@ | |||
2020-04-21 Frank Mittelbach <Frank.Mittelbach@latex-project.org> | |||
2020-04-22 Ulrike Fischer<Ulrike.Fischer@latex-project.org> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space before email address for consistency I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2 spaces in front of my name or David's name are automatically placed there by the workflow we use in emacs (pressing C-c c and getting most of the line autoinserted in the right changes file), so removing it for consistency is probably counterproductive as 99% of the changes (at the moment are done by us 2 :-). So I would rather add a space in front of Ulrike's name if we care about consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's kind of what I meant although I missed there were two spaces :)
Ulrike has now added a space before her address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, she added one after her name but removed the second space(s) from the line with my name. Not that it matters to me, I was just explaining that whenever I generate such a line it will have those spaces in as they are auto-generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrankMittelbach yes, sorry, some "autocorrecting space stuff" from my editor kicked in (that was also what remove the one trailing space later one), but I didn't really realize that it would remove spaces when I touch the line. I readded both now.
@@ -3601,7 +3603,7 @@ | |||
\xdef\@fontenc@load@list{\@fontenc@load@list | |||
\@elt{\csname opt@fontenc.sty\endcsname}} | |||
% \end{macrocode} | |||
% | |||
% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for including this -- we should purge all trailing whitespace! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I don't think that it was me, so either git or windows should get the praise.
there was a small typo, =Y and =y pointed to the same value.
Status of pull request
Checklist of required changes before merge will be approved
\changes
entries in source includedchanges.txt
updatedltnewsX.tex
updated