Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlig em dash ligature is broken #44

Closed
u-fischer opened this issue Feb 23, 2019 · 5 comments
Closed

tlig em dash ligature is broken #44

u-fischer opened this issue Feb 23, 2019 · 5 comments

Comments

@u-fischer
Copy link
Member

(moved from dev-luatex)

--- doesn't give an em-dash if there are no spaces around it (but curriously a hyphen before change this).

context doesn't have a problem. The problem is still there in the newest branch (v2.9603-...).
It works with texlive2017 (and the same fontloader), which seems to imply some engine change but older cache content could play a role here too.


\input luaotfload.sty
\font\test={name:texgyreheros:+tlig;}\test

em dashes---these % gives en-dash

em-dashes---these % gives em-dash

en dash--these %ok

\bye

image

@zauguin
Copy link
Member

zauguin commented Feb 23, 2019

I can not reproduce the difference in behaviour depending on the hyphen but always get a en-dash. Apart from that, the regression was introduced in c98b44c which only updated the fontloader. Also it can be reproduced using the plain fontloader:

\input plainfontloader.tex
\font\test={file:texgyreheros-regular.otf:+tlig;mode=node;}\test

dashes-these % gives dash

dashes--these % gives en-dash

dashes---these % gives en-dash
\bye

@u-fischer This seems like an upstream bug. I currently do not have a working ConTeXt install to investigate, so I can't tell why ConTeXt isn't affected. Is ConTeXt using mode=node or mode=base for this font?

@u-fischer
Copy link
Member Author

Ah, good, not our fault ;-). With mode=node I see the problem too. I sent a message to the context list, but I don't want to wait until this is fixed, but will try to upload new version anyway.

@u-fischer
Copy link
Member Author

@zauguin it looks as if we should put \automatichyphenmode=1 (or the lua equivalent tex.automatichyphenmode=1 ) somewhere. Do you have suggestion for a sensible place? (Hans will put it in the plain fontloader too, but I don't know yet, where exactly).

@zauguin
Copy link
Member

zauguin commented Feb 23, 2019

I think the default value of \automatichyphenmode should be made by the format, so in the LaTeX kernel.
If you want to set this in luaotfload through, I think luaotfload-init.lua would be the best location: Add a third entry in init_post_actions.

@u-fischer
Copy link
Member Author

@zauguin I agree, \XeTeXdashbreakstate is set in the format, and so the luatex setting should there be too. I'm just discussing it on the team list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants