-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Identical blocks might break dependecy_graph #176
Comments
A quick solution I can think of is to remove that method since |
It should, as we are only ever using it in a debug file to view the graph. I think working on this class is lower priority than anything in the UF epic, so I think it's fine to leave this for now, but good to have the issue logged if we do start to use it. |
If we go back to the plan of parallelizing operations |
I think it will also break this: lattice-surgery-compiler/src/lsqecc/logical_lattice_ops/dependency_graph.py Lines 113 to 116 in faad034
Which is part of the DAG generating method, with |
Yeah I will fix the type annotations in there as well. They are a mess 😓 |
lattice-surgery-compiler/src/lsqecc/logical_lattice_ops/dependency_graph.py Lines 41 to 45 in faad034
lol I override |
It's good we have all these notes. Don't think we need to act on it yet. |
Issue Description
This line suggests it:
lattice-surgery-compiler/src/lsqecc/logical_lattice_ops/dependency_graph.py
Line 134 in faad034
If two blocks are identical they will be interpreted as the same key in this map which doesn't sounds like the desired behavior.
Proposed Solution
Need to investigate if this is the case and find a solution. Also the code in
dependency_graph.py
is very hard to read because it's missing type annotations. Especially because it's generic/templated code it should be annotated.Additional References
The equivalence of rotations
lattice-surgery-compiler/src/lsqecc/pauli_rotations/rotation.py
Lines 172 to 177 in faad034
and measurements
lattice-surgery-compiler/src/lsqecc/pauli_rotations/rotation.py
Lines 211 to 216 in faad034
The text was updated successfully, but these errors were encountered: