feat: increase network performance by reducing unnecessary rpc calls #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alvrs
commented
Sep 28, 2022
•
alvrs
commented
- send raw transactions instead of via ethers method to avoid unnecessary rpc roundtrips for data we don't need
- process transaction queue concurrently
alvrs
force-pushed
the
ludens/network-boost
branch
from
0046932
to
28437d5
Compare
alvrs
changed the title
ludns
reviewed
Sep 29, 2022
| const { txQueue, dispose: disposeTxQueue } = createTxQueue(contracts, network, { devMode: networkConfig.devMode }); | ||
| const gasPriceInput$ = new BehaviorSubject<number>( | ||
| // If no initial gas price is provided, check the gas price once and add a 30% buffer | ||
| options?.initialGasPrice || (await signerOrProvider.get().getGasPrice()).toNumber() * 1.3 |
There was a problem hiding this comment.
probably want to make sure this is not a float; it might make the nodes freak out.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
…ng unnecessary rpc calls (#165) * feat: faster network [wip] * feat: no network check provider * feat: not wait for stuff you don't care about * chore: wip * chore: clean up * chore: self-review * test: add chainId to provider config * feat(network): add gasPriceInput$ to txQueue * fix(network): make sure initial gas price is an integer value Co-authored-by: ludens <ludens@lattice.xyz>
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
…pc calls (latticexyz#165) * feat: faster network [wip] * feat: no network check provider * feat: not wait for stuff you don't care about * chore: wip * chore: clean up * chore: self-review * test: add chainId to provider config * feat(network): add gasPriceInput$ to txQueue * fix(network): make sure initial gas price is an integer value Co-authored-by: ludens <ludens@lattice.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.