Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solecs): better inheritance for Component and BareComponent #229

Merged
merged 2 commits into from Nov 3, 2022

Conversation

dk1a
Copy link
Member

@dk1a dk1a commented Nov 1, 2022

Allow overriding Component logic (except access control)
And add some code reuse internally so Component inherits BareComponent

@dk1a dk1a requested a review from alvrs as a code owner November 1, 2022 07:00
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thank you!

@alvrs alvrs changed the title feat(solecs): better inheritance for Component and BareComponent refactor(solecs): better inheritance for Component and BareComponent Nov 3, 2022
@alvrs alvrs changed the title refactor(solecs): better inheritance for Component and BareComponent feat(solecs): better inheritance for Component and BareComponent Nov 3, 2022
@alvrs alvrs merged commit d4f5a4b into latticexyz:main Nov 3, 2022
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
…r inheritance (#229)

Co-authored-by: alvarius <89248902+alvrs@users.noreply.github.com>
@dk1a dk1a deleted the dk1a/solecs branch November 3, 2022 15:42
LPSCRYPT pushed a commit to LPSCRYPT/esp that referenced this pull request Jan 23, 2023
…atticexyz#229)

Co-authored-by: alvarius <89248902+alvrs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants