Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hanging test #2826

Closed
holic opened this issue May 14, 2024 · 1 comment
Closed

fix hanging test #2826

holic opened this issue May 14, 2024 · 1 comment

Comments

@holic
Copy link
Member

holic commented May 14, 2024

(from #2823 (comment))

packages/store-sync test:ci: close timed out after 500ms
packages/store-sync test:ci: Failed to terminate worker while running /home/runner/work/mud/mud/packages/store-sync/src/recs/recsStorage.test.ts.
packages/store-sync test:ci: Tests closed successfully but something prevents Vite server from exiting
packages/store-sync test:ci: You can try to identify the cause by enabling "hanging-process" reporter. See https://vitest.dev/config/#reporters

maybe related:
vitest-dev/vitest#3077
nodejs/undici#2026 (comment)

sounds like maybe bumping to node >=18.20.1 could fix the above

in the meantime, we can add some CI timeouts like in #2768 to ensure this doesn't run longer than it should

@holic
Copy link
Member Author

holic commented May 23, 2024

node bumped and timeout added in #2836

@holic holic closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant