Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate codegen index.sol pattern #2838

Open
holic opened this issue May 15, 2024 · 0 comments
Open

deprecate codegen index.sol pattern #2838

holic opened this issue May 15, 2024 · 0 comments

Comments

@holic
Copy link
Member

holic commented May 15, 2024

I thought this pattern would be nice to simplify importing codegen things from one place, e.g.

import { Tables, ResourceIds, StoreHooks } from "./codegen/index.sol";

but it turns out ANY changes to things imported in this index.sol file, even if its not imported into the user project, will change the resulting bytecode of the contract doing the import.

We should probably deprecate/discourage this pattern for better deterministic deploys. We should also migrate our usages before we tackle #2835.

@holic holic changed the title deprecate index.sol pattern deprecate codegen index.sol pattern May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant