fix: Flutter client should depend only on common client. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Jan 30, 2024
| @@ -14,8 +14,7 @@ dependencies: | |||
| sdk: flutter | |||
| package_info_plus: ^5.0.1 | |||
| device_info_plus: ^9.1.1 | |||
| launchdarkly_common_client: 0.1.0 | |||
| launchdarkly_dart_common: 0.0.2 | |||
kinyoklion
commented
Jan 30, 2024
| @@ -14,8 +14,7 @@ dependencies: | |||
| sdk: flutter | |||
| package_info_plus: ^5.0.1 | |||
| device_info_plus: ^9.1.1 | |||
| launchdarkly_common_client: 0.1.0 | |||
| launchdarkly_dart_common: 0.0.2 | |||
| launchdarkly_common_client: 1.0.0 | |||
There was a problem hiding this comment.
This will need updated again after the publish.
…arkly/flutter-client-sdk into rlamb/fix-dependency-propagation
kinyoklion
commented
Jan 30, 2024
| @@ -3,16 +3,13 @@ | |||
| "separate-pull-requests": true, | |||
| "packages": { | |||
| "packages/common": { | |||
There was a problem hiding this comment.
All, the 1.0.0 have been released, so now those should auto-bump from now on.
louis-launchdarkly
approved these changes
Jan 30, 2024
This was referenced Jan 30, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Jan 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.1](launchdarkly_common_client-v1.0.0...launchdarkly_common_client-v1.0.1) (2024-01-30) ### Bug Fixes * Flutter client should depend only on common client. ([#113](#113)) ([edfd06d](edfd06d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kinyoklion
added a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](4.0.0-alpha.1...4.0.0) (2024-01-31) This version of the SDK has been re-written in dart and now supports Android, iOS, Windows, macOS, Linux, and Web. The previous versions were wrappers which utilized our native Android and iOS SDKs. A migration guide will be available in our [docs](https://docs.launchdarkly.com/sdk/client-side/flutter). ### Features * Add example project. ([#93](#93)) ([588ae01](588ae01)) * Implement support for REPORT for streaming. ([#96](#96)) ([1de6079](1de6079)) * Use version 1.0.1 of common client. ([#115](#115)) ([cd85c65](cd85c65)) ### Bug Fixes * Check for network state on resume. ([#95](#95)) ([c1cb489](c1cb489)) * Correct timeout handling in example. ([#97](#97)) ([dc18529](dc18529)) * Flutter client should depend only on common client. ([#113](#113)) ([edfd06d](edfd06d)) * Mac entitlements. Clarifications. ([#107](#107)) ([077e9aa](077e9aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the flutter SDK directly depended on common. This was because common client was missing some re-exports. This fixes that. So I will release the patch of common client after merging this. Then do the final version number updates.