feat: Support latest versions of the plus plugins. #148
Conversation
| @@ -23,7 +23,8 @@ final class FlutterStateDetector implements StateDetector { | |||
| Stream<NetworkState> get networkState => _networkStateController.stream; | |||
|
|
|||
| late final LDAppLifecycleListener _lifecycleListener; | |||
| late final StreamSubscription<ConnectivityResult> _connectivitySubscription; | |||
There was a problem hiding this comment.
I am a little concerned about also requiring an upgrade to a package that has only been out a few days.
Ideally we could support both for a bit. Probably not elegant, but I wonder if we could wrap these couple contact points. Accept a dynamic, if the item is not a list, then turn it into a list of one, if it is a list then forward it along.
There was a problem hiding this comment.
Definitely not elegant, but it's not a bad idea! I just updated this PR, it should do the trick.
I thought about writing a wrapper as you suggested, but it looks like it's really just this one little spot in the code that needs to handle connectivity_plus v5, so I thought I'd keep it simple.
There was a problem hiding this comment.
@maxlapides Looks great. Thank you for the contribution!
|
@maxlapides Thank you for the contribution! I've added a couple comments, and we will need a little time to consider. |
kinyoklion
changed the title
|
I changed the PR title to ensure that it is releasable via release-please. It is a "feat" which would correspond to a minor version bump. |
🤖 I have created a release *beep* *boop* --- ## [4.4.0](4.3.0...4.4.0) (2024-03-27) ### Features * Support latest versions of the plus plugins. ([#148](#148)) ([98dbbed](98dbbed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
@maxlapides This has been released in 4.4.0. Thanks again for the contribution! |
|
Thanks so much @kinyoklion! |
Requirements
Related issues
It's not currently possible to upgrade the Flutter plus plugins in projects that require the LaunchDarkly SDK until the LaunchDarkly SDK upgrades its dependencies.
Describe the solution you've provided
Upgraded the dependencies.
Describe alternatives you've considered
N/A
Additional context
N/A